osTicket Community Forums

sprintf error in class.email.php

I was having some trouble getting osticket working with our mail system...

It turns out the errors were never output:

--- /var/www/default/htdocs/include/class.email.php~
+++ /var/www/default/htdocs/include/class.email.php
@@ -194,7 +194,7 @@
if(!PEAR::isError($result))
return true;

- $alert=sprintf("Unable to email via %s:%d [%s]\n\n%s",$smtp['host'],$smtp['port'],$smtp['username']);
+ $alert=sprintf("Unable to email via %s:%d [%s]\n\n",$smtp['host'],$smtp['port'],$smtp['username']);
Sys::log(LOG_ALERT,'SMTP Error',$alert,false);
//print_r($result);
}

Just a thought, but as sprintf seems to be used for error output it might be worth double checking to see if this occurs anywhere else?

btw. Thanks for the excellent project and readable code - it's great - I should have implemented years ago.

The issue is fixed on the latest version - please upgrade.

Thanks for the response Peter! Am I misunderstanding the latest version though? I was using the Feb 1.6 stable release - does that download itself change? Or is there an SVN / snapshot I should be downloading / following updates to?
Thanks again!

Mitch,

I'm not sure when you downloaded the code but the latest version has the following -
Simply diff the latest release with your install to see any other changes - I could have updated the the latest version.